Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages from with_columns() is difficult to understand when extra comma #600

Closed
eitsupi opened this issue Dec 17, 2023 · 1 comment · Fixed by #607
Closed

Error messages from with_columns() is difficult to understand when extra comma #600

eitsupi opened this issue Dec 17, 2023 · 1 comment · Fixed by #607
Assignees
@sorhawell
Labels
enhancement New feature or request

Comments

@eitsupi
Copy link
Collaborator

eitsupi commented Dec 17, 2023

The meaning of this error is quite difficult to understand. The easiest way to fix this is to use rlang::list2, but we can't do that here, so this error should be allowed.

> pl$DataFrame(mtcars)$with_columns(foo = TRUE,)
Error in unpack_list(...) : argument is missing, with no default

Originally posted by @eitsupi in #598 (comment)
@eitsupi eitsupi mentioned this issue Dec 17, 2023
Merged
@eitsupi
Copy link
Collaborator Author

eitsupi commented Dec 17, 2023

Same issues also exist with filter and when.

@eitsupi eitsupi added the enhancement New feature or request label Dec 17, 2023
@sorhawell sorhawell self-assigned this Dec 17, 2023
@sorhawell sorhawell mentioned this issue Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorhawell sorhawell

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve unpack_list error pola-rs/r-polars
2 participants
@sorhawell @eitsupi