Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove deprecated functions for version 0.13.0 #714

Merged
merged 4 commits into from
Jan 20, 2024
Merged

refactor!: remove deprecated functions for version 0.13.0 #714

merged 4 commits into from
Jan 20, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Jan 19, 2024

No description provided.

@eitsupi eitsupi marked this pull request as ready for review January 19, 2024 13:58
@eitsupi eitsupi added this to the 0.13 milestone Jan 19, 2024
etiennebacher
etiennebacher reviewed Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM but I think we can keep that aside and merge it just before 0.13.0 so that we can release 0.12.3 in the meantime if we need to

NEWS.md Outdated Show resolved Hide resolved
@eitsupi
Copy link
Collaborator Author

eitsupi commented Jan 20, 2024

but I think we can keep that aside and merge it just before 0.13.0 so that we can release 0.12.3 in the meantime if we need to

Good point. But I think it would be better to make the next version 0.13.0, since it already pulls in breaking changes.

@eitsupi eitsupi merged commit a89d18e into main Jan 20, 2024
17 checks passed
@eitsupi eitsupi deleted the remove-old-funcs branch January 20, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eitsupi @etiennebacher