Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove <Expr>$where #718

Merged
merged 3 commits into from
Jan 20, 2024
Merged

refactor!: remove <Expr>$where #718

merged 3 commits into from
Jan 20, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Jan 20, 2024

Same as pola-rs/polars#13440

Perhaps this is not used as often as it should be, and I would like to remove it rather than deprecate it.

@eitsupi eitsupi added this to the 0.13 milestone Jan 20, 2024
@etiennebacher
Copy link
Collaborator

I'd rather deprecate it than removing it at once. At least people can have a helpful message about how to fix their code during a few weeks and it doesn't cost much to us

@eitsupi
Copy link
Collaborator Author

eitsupi commented Jan 20, 2024

I'd rather deprecate it than removing it at once. At least people can have a helpful message about how to fix their code during a few weeks and it doesn't cost much to us

Ideally, yes, but our development resources are limited.
I also imagine that there would be no problem removing this function immediately, given that there would be few users.

@eitsupi
Copy link
Collaborator Author

eitsupi commented Jan 20, 2024

Personally, the deprecation of Python Polars is of little use to me because the release rate is too fast.
Often the code I run after several months is no longer working without issuing a warning. I end up having to search GitHub to fix the code, so it makes no difference to me whether I go through the deprecation or not.

I find the deprecation process to be of little value unless it is done over a sufficiently long period of time. (For example, the Tidyverse packages take years to remove deprecated functions, right?)

I do not want to go through deprecation on this, as I believe the priority now is development speed. (Of course I would prefer to go through deprecation for very commonly used functions, but as for where, I am sure almost no one uses it.)

@etiennebacher
Copy link
Collaborator

I'm fine with that, thanks for the explanations (I didn't even know $where() before actually)

@eitsupi
Copy link
Collaborator Author

eitsupi commented Jan 20, 2024

(It appears that some whitespace has been removed as a result of auto-formatting.)

@eitsupi eitsupi merged commit 6f48dae into main Jan 20, 2024
17 checks passed
@eitsupi eitsupi deleted the remove-where branch January 20, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants