-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite arrow_to_rdf
and arrow_to_rseries_result
#727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there also a way to add a test reproducing #725 or would that be too hard to add in unit test?
Of course I'll add it. Something like below (this crashes in current release version) da_string = arrow::Array$create(
factor(c("x", "y", "z"))
)
da_large_string = da_string$cast(
arrow::dictionary(
index_type = arrow::uint32(),
value_type = arrow::large_utf8()
)
)
at = arrow::arrow_table(foo = da_string, bar = da_large_string)
as_polars_df.ArrowTabular(at) |
a453b83
to
9679845
Compare
arrow_to_rdf
and arrow_to_rseries_result
arrow_to_rdf
and arrow_to_rseries_result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fix #725, part of #677
After rewriting the contents of the functions with reference to Python Polars, the bug #725 seems to have been fixed.
(I'm not sure where the bug was occurring after all)
Other improvements:
as_polars_df
forRecordBatch
now works.as_polars_series
forArray
andChunkedArray
are added.These changes have completely ported
pl$from_arrow
's functionality toas_polars_*
, so we can deprecatepl$from_arrow
in a follow-up PR.