Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: $sort() no longer panicks when descending = NULL #748

Merged
merged 3 commits into from
Jan 30, 2024
Merged

fix: $sort() no longer panicks when descending = NULL #748

merged 3 commits into from
Jan 30, 2024

Conversation

etiennebacher
Copy link
Collaborator

Close #733
Close #734 (which will be hard to replicate now that #733 is fixed)

eitsupi
eitsupi approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@etiennebacher etiennebacher merged commit d2d3daf into main Jan 30, 2024
23 checks passed
@etiennebacher etiennebacher deleted the fix-sort-panick branch January 30, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running twice some code that panicks generates a segfault $sort() panicks if descending = NULL
2 participants
@etiennebacher @eitsupi