refactor: rewrite S3 methods of arrow and nanoarrow package functions
#754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
commented
Jan 31, 2024
etiennebacher
approved these changes
Jan 31, 2024
| #' | ||
| #' pl_df = as_polars_df(mtcars) | ||
| #' as_arrow_table(pl_df) | ||
| # exported in zzz.R |
There was a problem hiding this comment.
Suggested change
| # exported in zzz.R | |
| # exported in zzz.R: this generic belongs to `arrow` and we only export the method if | |
| # `arrow` is already loaded when we load `polars` |
just a note for future us
There was a problem hiding this comment.
There are similar things elsewhere, so if you are interested, please change them all by another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as_arrow_tableandas_record_batch_readerfor RPolarsDataFrame no longer neednanoarrow