Implement <DataFrame>$flags and improve <Series>$flags
#809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
requested changes
Feb 13, 2024
|
Sorry, it is the Python world that calls such things "attributes", and here (in R) "active bindings" was appropriate. |
eitsupi
approved these changes
Feb 16, 2024
eitsupi
reviewed
Feb 16, 2024
| #' - `SORTED_DESC` is similar but applies to sort in decreasing order. | ||
| #' | ||
| #' @details Check out the source code in | ||
| #' [R/dataframe_frame.R](https://github.com/pola-rs/r-polars/blob/main/R/dataframe__frame.R) |
There was a problem hiding this comment.
I don't think such things should be placed here (they should be in the developer's documentation), but since they are irrelevant to this PR, I'll leave them alone.
eitsupi
reviewed
Feb 16, 2024
R/dataframe__frame.R
Outdated
| @@ -74,6 +94,15 @@ | |||
| NULL | |||
|
|
|||
|
|
|||
| DataFrame_flags = method_as_property(function() { | |||
| out = lapply(self$columns, \(x) { | |||
| self[x]$to_series()$flags | |||
There was a problem hiding this comment.
to_series() is needed here?
How about self[, x]?
There was a problem hiding this comment.
How about self[, x]?
Yes that's simpler, good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One issue here is that I'm actually not sure what the
"FAST_EXPLODE"actually means (which is why I didn't explain in the docs)