Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: rewrite active bindings and sub-namespaces #819

Merged
merged 22 commits into from
Feb 20, 2024
Merged

refactor: rewrite active bindings and sub-namespaces #819

merged 22 commits into from
Feb 20, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Feb 18, 2024 •
edited
Loading

Close #255 (Rewrite of #810)
Close #772
Close #813

Rewrite the documents for active bindings (and sub-namespaces) to include them in the docs for each class.

@eitsupi eitsupi changed the title docs: update documents for classes to include active bindings docs: update documents for classes to include active bindings (and sub-namespaces) Feb 18, 2024
@eitsupi eitsupi changed the title docs: update documents for classes to include active bindings (and sub-namespaces) refactor: rewrite active bindings and sub-namespaces Feb 18, 2024
@eitsupi eitsupi marked this pull request as ready for review February 18, 2024 07:56
@etiennebacher etiennebacher mentioned this pull request Feb 18, 2024
Closed
@eitsupi eitsupi added this to the 0.14 milestone Feb 18, 2024
@eitsupi
Copy link
Collaborator Author

eitsupi commented Feb 18, 2024

@etiennebacher Could you take a look at this?

etiennebacher
etiennebacher requested changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, those are great docs improvements!

I have a couple of comments on the subnamespaces for Series

R/dataframe__frame.R Outdated Show resolved Hide resolved
R/expr__expr.R Show resolved Hide resolved
R/series__series.R Outdated Show resolved Hide resolved
R/series__series.R Show resolved Hide resolved
R/series__series.R Outdated Show resolved Hide resolved
tests/testthat/test-series_string.R Outdated Show resolved Hide resolved
etiennebacher
etiennebacher requested changes Feb 19, 2024
View reviewed changes
R/expr__expr.R Show resolved Hide resolved
R/series__series.R Show resolved Hide resolved
etiennebacher
etiennebacher approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice refactoring, thanks @eitsupi

@etiennebacher etiennebacher merged commit 41e3512 into main Feb 20, 2024
18 checks passed
@etiennebacher etiennebacher deleted the active-bindings branch February 20, 2024 07:12
This was referenced Feb 20, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebacher etiennebacher etiennebacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14
2 participants
@eitsupi @etiennebacher