feat: make $otherwise optional in when-then-otherwise expressions
#836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
changed the title
$then(...)$then(...)
eitsupi
force-pushed
the
optional-otherwise
branch
from
488e6c8
to
88ffd99
Compare
eitsupi
changed the title
$then(...)$otherwise optional in when-then-otherwise expressions
eitsupi
force-pushed
the
optional-otherwise
branch
from
88ffd99
to
a4cd671
Compare
etiennebacher
requested changes
Feb 23, 2024
| #' `$otherwise()` when you arrive at the end of your chain. | ||
| #' Note that one difference with the Python implementation is that we *must* | ||
| #' end the chain with an `$otherwise()` statement. | ||
| #' `when-then-otherwise` is similar to R [`ifelse()`]. Always initiated by a |
There was a problem hiding this comment.
Suggested change
| #' `when-then-otherwise` is similar to R [`ifelse()`]. Always initiated by a | |
| #' `when-then-otherwise` is similar to R [`ifelse()`]. It is always initiated by a |
There was a problem hiding this comment.
In fact, this text is copied from the Python package, so I would like to leave it as is.
| #' * `<ChainedThen>$otherwise()`returns an [Expression][Expr_class] object. | ||
| #' If none of the conditions are `true`, an optional | ||
| #' `$otherwise(<value if all statements are false>)` can be appended at the end. | ||
| #' If not appended, and none of the conditions are `true`, `null` will be returned. |
There was a problem hiding this comment.
Suggested change
| #' If not appended, and none of the conditions are `true`, `null` will be returned. | |
| #' If not appended, and none of the conditions are `true`, it will return `null`. |
etiennebacher
approved these changes
Feb 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #599