Implement $str$extract_groups()
#979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eitsupi this failure with R-devel on windows has been here for a week or so, do you know what's happening?
Is it a problem related to Rtools 4.4? |
|
I believe this is separate from the R-devel problem that has been occurring recently. Maybe fixed by #981 |
eitsupi
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #975
@Yunuuuu as you can see there isn't much Rust to implement for this kind of feature. What I do in general is refer to the original PR in python-polars (in this case, this one: https://github.com/pola-rs/polars/pull/10179/files). There are a bunch of changes but we're only interested in the last 4 files which implement the documentation and make the connection between Rust and python.
Feel free to ask questions if you're interested in this