Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: by -> group_by in $rolling() and $group_by_dynamic() #983

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Mar 29, 2024

No description provided.

Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Just two minor comments on error messages

R/expr__expr.R Outdated Show resolved Hide resolved
R/lazyframe__lazy.R Outdated Show resolved Hide resolved
Co-authored-by: Etienne Bacher <52219252+etiennebacher@users.noreply.github.com>
@eitsupi eitsupi merged commit 0c3ce3c into main Mar 30, 2024
@eitsupi eitsupi deleted the rolling-group_by branch March 30, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants