Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I looked at the entire code base, but did not do go fmt, which does not conform to the go code specification #16

Closed
daheige opened this issue Sep 23, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@daheige
Copy link
Member

daheige commented Sep 23, 2021

As a well-known manufacturer at home and abroad, even the basic go code specifications have not been done well. It looks really uncomfortable. The last project was the polaris project. I can't think of this polaris-go as well. Is this the style of the big factory? It's really low. It is recommended that you first standardize the code, go fmt the code, and then open it to the outside world. Don't you big manufacturers feel ashamed?

Even if you use vim or vscode editors, you can do some basic code formatting after writing the code. It is recommended to use the goland editor and the golanglint tool. It is fine to format the code of the entire project once. At the very least, when someone else contributes to you, it will look more comfortable and not so uncomfortable.

The code is written for people to see. If the open source code is presented to go developers or trailblazers, it should be carefully polished, rather than being fine after writing, and then executing go build, no matter what. This is not the style of an open source project. As a large company that has attracted much attention from the industry, you should reflect on which link has gone wrong, whether open source has not been properly checked, or whether your go developers are at this level, then Just huh.

@daheige daheige added the enhancement New feature or request label Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants