Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to an range input slider #11

Open
vilav opened this issue Jan 19, 2017 · 9 comments
Open

Connecting to an range input slider #11

vilav opened this issue Jan 19, 2017 · 9 comments

Comments

@vilav
Copy link

vilav commented Jan 19, 2017

Hi there,

Of most plugins out there, found turntable to be quite performant on mobile. Noob Question: Any ideas on officially adding support for the range input for the plugin? Or any guidance to readily connect it at present?

Thanks!

@morganjlopes
Copy link
Member

morganjlopes commented Jan 19, 2017 via email

@vilav
Copy link
Author

vilav commented Jan 19, 2017

Hi Morgan,

I meant a slider as an added controller for the 360 movement. Found the following demo as an example:
http://codepen.io/pixelthing/pen/kkxpqo

There is a pull request to your repository but the slider doesnt seem to update in relation to the 360.

Thanks

@morganjlopes
Copy link
Member

morganjlopes commented Jan 19, 2017 via email

@ibarsi
Copy link

ibarsi commented Jan 19, 2017

Hey @vilav,

It's been a while since I submitted that pull request. If you're interested in this feature, id be happy to look into it and ensure it's ready to be merged.

@vilav
Copy link
Author

vilav commented Jan 19, 2017

@ibarsi that would be awesome, if you could! It's a very nifty feature you added in the PR!

@ibarsi
Copy link

ibarsi commented Jan 21, 2017

@vilav I've committed an update to the input slider, it now sets it's min/max/step values in relation to 360 degrees (much like the pen you commented as an example).

Here's a fiddle that shows it in action:
https://jsfiddle.net/ibarsi/LLh3prgo/1/

Let me know if this is what you had in mind.

@vilav
Copy link
Author

vilav commented Jan 23, 2017

awesome, thanks @ibarsi! trying it out now, keep you posted with findings!

@vilav
Copy link
Author

vilav commented Jan 24, 2017

hi @ibarsi, the slider works great on desktop. but on mobile the slider handle doesn't seem to update. so when I drag the slider, the 360 still works but the position of the handle of the slider doesn't update position. any way to fix that / or does it need a plugin like NoUISlider? (https://refreshless.com/nouislider/)

@ibarsi
Copy link

ibarsi commented Jan 26, 2017

@vilav Yeah, that mainly comes down to a lack of range input support in some browsers (especially mobile). I simply wanted to add generic support for the base range input element, that way implementers can decide to use any range UI library in conjunction to create whatever experience they desire.

Have you tried a lib like noUiSlider, does it play nice with turntable' range input support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants