Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add final stage to the logic of physical plan planning #207

Open
metalmatze opened this issue Sep 23, 2022 · 5 comments
Open

Add final stage to the logic of physical plan planning #207

metalmatze opened this issue Sep 23, 2022 · 5 comments
Labels
enhancement New feature or request planned Planned work wont get closed by stalebot

Comments

@metalmatze
Copy link
Member

Instead of adding the final stage boolean to the physical plan execution, I think this logic should be part of the physical plan planning. i.e. when planning a multi-stage count, instead of planning a count(final=true) operator, you would just plan a sum() operator at the final stage.

Originally posted by @asubiotto in #202 (comment)

Copy link

github-actions bot commented Jan 5, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 5, 2024
@asubiotto
Copy link
Contributor

I think this would still be worth keeping open, we should remove the booleans from the constructor and instead have the physical planner create these aggregations.

@github-actions github-actions bot removed the Stale label Jan 8, 2024
@asubiotto asubiotto added the enhancement New feature or request label Feb 1, 2024
Copy link

github-actions bot commented Mar 3, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 3, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2024
@brancz brancz reopened this Mar 9, 2024
@github-actions github-actions bot removed the Stale label Mar 10, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 10, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 15, 2024
@asubiotto asubiotto reopened this Apr 15, 2024
@github-actions github-actions bot removed the Stale label Apr 16, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 16, 2024
@asubiotto asubiotto removed the Stale label May 16, 2024
@thorfour thorfour added the planned Planned work wont get closed by stalebot label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request planned Planned work wont get closed by stalebot
Projects
None yet
Development

No branches or pull requests

4 participants