Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MergeRecords can support array.Float64 sort? #720

Open
jicanghaixb opened this issue Feb 4, 2024 · 4 comments
Open

MergeRecords can support array.Float64 sort? #720

jicanghaixb opened this issue Feb 4, 2024 · 4 comments
Labels

Comments

@jicanghaixb
Copy link

MergeRecords function is very useful. Thank you for providing this function. but now not support *array.Float64 sort, can we support it?

Also, could we add a reverse sorting function MergeReverseRecords?

@metalmatze
Copy link
Member

Supporting float64 shouldn't be too difficult to add to the Less function: https://github.com/polarsignals/frostdb/blob/main/pqarrow/arrowutils/merge.go#L95-L142
We'd happily accept if you want to send a Pull Request.

Adding reverse sorting to merging seems possible. We would need to discuss what the API change would look like or if we should add another function like you proposed.

Do you have an example where sorting the records first and then merging the record wouldn't work?

Copy link

github-actions bot commented Mar 8, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 8, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@metalmatze metalmatze reopened this Mar 19, 2024
@github-actions github-actions bot removed the Stale label Mar 20, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 19, 2024
@asubiotto asubiotto removed the Stale label Apr 19, 2024
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants