Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page requires JS #2172

Open
zegl opened this issue Jan 9, 2024 · 7 comments
Open

404 page requires JS #2172

zegl opened this issue Jan 9, 2024 · 7 comments
Labels
bug Something isn't working could-have Nice to have feature of a bigger feat good first issue

Comments

@zegl
Copy link
Contributor

zegl commented Jan 9, 2024

I think it would be a good idea to at a minimum render something on 404 pages if JS is disabled.

@zegl zegl added bug Something isn't working good first issue could-have Nice to have feature of a bigger feat labels Jan 9, 2024
@appills
Copy link

appills commented Jan 9, 2024

I think it would be a good idea to slap a tag on every page if javascript is disabled

@zegl
Copy link
Contributor Author

zegl commented Jan 9, 2024

I think it would be a good idea to slap a tag on every page if javascript is disabled

Most pages work decently without JS, I would want the 404 state to render without JS too.

@sourabpramanik
Copy link

Is anybody working on this issue? I would like to work on it.

@zegl
Copy link
Contributor Author

zegl commented Jan 9, 2024

@sourabpramanik Not that I’m aware of. Please do, PRs welcome!

@sourabpramanik
Copy link

Alright thanks 👍

@webbdays
Copy link

webbdays commented Mar 7, 2024

Hi,
should we go for plain 404 page for all.
or should we check if the browser supports JS.
I think we can use
noscript tag.

@frankie567
Copy link
Member

FWIW, it seems that even the default 404 page does not work without JS. Next.js seems to always pick it up to inject its scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working could-have Nice to have feature of a bigger feat good first issue
Projects
Status: No status
Development

No branches or pull requests

5 participants