Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a separate worker queue for GitHub jobs #2761

Closed
frankie567 opened this issue Mar 6, 2024 · 2 comments · Fixed by #3161
Closed

Have a separate worker queue for GitHub jobs #2761

frankie567 opened this issue Mar 6, 2024 · 2 comments · Fixed by #3161
Labels
dx Efforts that help us ship faster, improve codebase etc

Comments

@frankie567
Copy link
Member

This morning, we had some timeout and rate limit errors on lot of GitHub sync jobs, which delayed processing of new jobs by almost an hour:

Capture d’écran 2024-03-06 à 09 24 26

It happens rarely but we have critical jobs (like Stripe subscriptions events) which should be handled quickly.

To avoid this, we could have a separate queue with a dedicated process only for GitHub sync, while leaving the other for critical jobs.

@frankie567 frankie567 added the dx Efforts that help us ship faster, improve codebase etc label Mar 6, 2024
@zegl
Copy link
Contributor

zegl commented Mar 6, 2024

(this is not a blocker for your idea above)

Agreed, and truth be told! A lot of these GitHub syncs can probably be removed. We're barely using issue_references and issue_dependencies, and they are a majority of all jobs executed!

@frankie567
Copy link
Member Author

Great call, @zegl. I even think it could be the first thing to consider before thinking about complex things like I propose above :) I'll open an issue for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Efforts that help us ship faster, improve codebase etc
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants