Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External payment with PayPal not loading #154

Closed
newhoa opened this issue Nov 22, 2021 · 5 comments
Closed

External payment with PayPal not loading #154

newhoa opened this issue Nov 22, 2021 · 5 comments
Labels
broken page NLNet project evaluation phase This issue should be evaluated during the evaluation phase of the JSR NLNet project

Comments

@newhoa
Copy link

newhoa commented Nov 22, 2021

This is using Firefox 94.0 on Linux

Many sites offer using Paypal to pay. When paying with Paypal, it opens a popup window to finish the payment process on Paypal in the popup window, then returns you to the site to finish the payment process.

jsrestrictor blocks this from loading/initializing. The popup window opens and the paypal circle spins, but nothing loads. The popup window has a limited toolbar, only showing the URL and Firefox Menu button, so jsrestrictor cannot be adjusted or disabled from there. Paypal must be manually disabled in the domain-specific configuration (for me I had to turn it to 0 - Wrappers Off).

Once the popup loads, the url begins paypal.com/checkoutnow. I don't know if that's helpful or can/should be whitelisted by default.

Not sure if this is a bug or working as intended. But I was a little confused as to what site was causing the issue (Paypal or the site launching Paypal) and then without the jsrestrictor button in the popup window it wasn't easily changed.

Let me know you need any more info on my part or need me to test anything.

Thanks.

@newhoa newhoa changed the title External payment with PayPal External payment with PayPal not loading Nov 22, 2021
@TechnologyClassroom
Copy link

I can confirm that I ran into this issue as well.

@polcak
Copy link
Owner

polcak commented Nov 23, 2021

This might also be worth reporting to Firefox. Why do they create windows without extension badge icons?

@BayLee4
Copy link

BayLee4 commented Jan 30, 2022

Setting browser.link.open_newwindow to 3 and browser.link.open_newwindow.restriction to 0 in about:config will force all popup windows (including the Paypal ones) to open in a new tab, meaning the JSRestrictor level could be adjusted easily everywhere.

Disabling the Clear window.name value on the webpage loading option (and Filter XMLHttpRequest requests + Protect against ArrayBuffer exploitation because of #164) makes PayPal work for me.

@polcak
Copy link
Owner

polcak commented Apr 22, 2022

Thank you @BayLee4 for the comment, I will use your suggestion in the FAQ.

window.name wrapper is disabled by default in latest versions for Firefox because all supported versions of Firefox offer good enough protection. We are working on mimicing the protection for Chromium-based browsers, see https://pagure.io/JShelter/webextension/issue/46.

I will close the issue but if you feel that there are additional steps that needs to be done, please let us know.

@polcak polcak closed this as completed Apr 22, 2022
@polcak polcak added the NLNet project evaluation phase This issue should be evaluated during the evaluation phase of the JSR NLNet project label Apr 22, 2022
@privacyguy123
Copy link

Sorry - I'm not understanding what the exact fix is here. When I set jshelter to whitelist PayPal.com the popup/new window checkout still fails to go through ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken page NLNet project evaluation phase This issue should be evaluated during the evaluation phase of the JSR NLNet project
Projects
None yet
Development

No branches or pull requests

5 participants