Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken sites from WebWorker protection on Firefox #195

Closed
brochard opened this issue Mar 27, 2023 · 3 comments
Closed

Broken sites from WebWorker protection on Firefox #195

brochard opened this issue Mar 27, 2023 · 3 comments
Labels
broken page duplicate This issue or pull request already exists

Comments

@brochard
Copy link

brochard commented Mar 27, 2023

Summary

I realised most broken sites I have is caused by the WebWorker protection so I gathered a list here and the level at which it works with no problem.

Setup

Pages affected:

JShelter Version: 0.11.2

Popup information (open JShelter popup on affected pages:

JavaScript Shield ON
Network Boundary Shield ON
Fingerprint Detector ON
Level: Recommanded

[Optional:]

OS: Windows 10
Browser: Firefox
Other extensions that might affect JShelter behaviour: Ublock Origin

How to reproduce

  1. Open site
  2. For overleaf only : connect to an account, create a document and see if it compiles on the right

Expected result

Site loading / Videos loading / pdf compiling / Captcha completing

Actual result

not loading

Reproducibility

Tested it with another clean Firefox Nightly and Brave

-> They're all broken on both instance of Firefox
-> None of those sites are broken one Brave

Workarounds

I gave the necessary WebWorker level for each of these

@polcak
Copy link
Owner

polcak commented Apr 3, 2023

Thank you. I added a link to this issue to https://pagure.io/JShelter/webextension/issue/80. I will close this one as a duplicate of the Pagure issue. If you have further comments, feel free to post here.

As posted in #199, I am not sure that we will try to fix this in MV2, we will try for MV3.

@polcak polcak closed this as not planned Won't fix, can't repro, duplicate, stale Apr 3, 2023
@polcak polcak added duplicate This issue or pull request already exists broken page labels Apr 3, 2023
@polcak
Copy link
Owner

polcak commented Apr 19, 2023

Hello @brochard,

once again, thank you for the list. I am now testing with the recently released 0.12.1 in Firefox.

Cryptpad (https://cryptpad.fr/drive/) works with all WebWorker policies,
Proton does not work
Element (https://app.element.io/) works but not sure if that is slowly or not
Gitlab diffing still broken

Firefox Low policy should be fixed, hopefully soon.

See FAQ. Currently, we are not aware of a reliable and safe way that can insert polyfills for the pages. Some pages insert their own polyfills and work others do not. So we changed the Strict policy to break Workers and added Remove policy. Those can potentially work or we leave the decision on users.

Still, the preferred solution is to inject polyfills so if there is a new API that would allow us to do so or we discover a reliable and safe way with current APIs, we might improve other sites.

@brochard
Copy link
Author

brochard commented Apr 19, 2023

Thank you for keeping us updated @polcak
(For element if it doesn't take 30seconds to load then it's not slow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
broken page duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants