Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Implemented crash #13

Open
steven-spiel opened this issue Jun 30, 2021 · 1 comment
Open

Not Implemented crash #13

steven-spiel opened this issue Jun 30, 2021 · 1 comment

Comments

@steven-spiel
Copy link

Screen Shot 2021-06-30 at 1 18 53 PM

We are using 0.1.3 and observed this crash coming from onDetachedFromActivity in OptimizelyPlugin.kt link to code

I didn't think a TODO would crash an app, but I thought I'd let you know about it.

@kevin49999
Copy link
Contributor

kevin49999 commented Jul 2, 2021

Thanks for pointing this out @steven-spiel. It may make sense to change those to comments like in the example here: https://flutter.dev/docs/development/packages-and-plugins/plugin-api-migration or just remove them since I don't think we need to do any cleanup in these methods for this plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants