Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create ci.yaml #5

Merged
merged 2 commits into from Dec 16, 2020
Merged

Create ci.yaml #5

merged 2 commits into from Dec 16, 2020

Conversation

kevin49999
Copy link
Contributor

@kevin49999 kevin49999 commented Dec 16, 2020 •
edited

Add GitHub action that runs flutter tests on PR and also creates a starting point to add more.

Description

Add ci.yaml to support running flutter tests on PRs to main

Motivation and Context

We have tests we're running locally but should run before PRs are merged, it's also a nice starting point for adding more GHAs (release, etc.)

Type of Change:

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Maintenance or Refactor

Checklist

  • I added tests to cover my changes
  • I rebased changes with master so that they can be merged easily
  • I have updated the documentation accordingly (if applicable)

@kevin49999 kevin49999 requested review from maxnovak, vkatz-pg, a team and yurykorzun and removed request for a team December 16, 2020 17:25
maxnovak
maxnovak reviewed Dec 16, 2020
View reviewed changes
.github/workflows/ci.yaml Outdated

on:
pull_request:
paths:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need paths? Since there is just one package this feels like kinda overkill here. We probably want it to run for everything.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, removed!

maxnovak
maxnovak approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@maxnovak maxnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevin49999 kevin49999 merged commit 9a5518e into main Dec 16, 2020
@kevin49999 kevin49999 deleted the flutter-gha branch December 16, 2020 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxnovak maxnovak maxnovak approved these changes

@vkatz-pg vkatz-pg Awaiting requested review from vkatz-pg

@yurykorzun yurykorzun Awaiting requested review from yurykorzun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevin49999 @maxnovak