Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async init #7

Merged
merged 8 commits into from Jan 21, 2021
Merged

Async init #7

merged 8 commits into from Jan 21, 2021

Conversation

vkatz-pg
Copy link
Contributor

Description

Added what Optimizely calls asynchronous manager initialization.

Motivation and Context

There are cases when we need to make sure that the datafile is downloaded first before we return from manager initialization function. This addition allows just that. More info can be found here.

Type of Change:

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Maintenance or Refactor

Checklist

  • I added tests to cover my changes
  • I rebased changes with master so that they can be merged easily
  • I have updated the documentation accordingly (if applicable)

yurykorzun
yurykorzun previously approved these changes Jan 20, 2021
@yurykorzun yurykorzun dismissed their stale review January 20, 2021 18:03

Approved by mistake

Copy link
Contributor

@maxnovak maxnovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have to bump the version number in this PR or is that a separate PR?

@vkatz-pg
Copy link
Contributor Author

vkatz-pg commented Jan 21, 2021

Do we have to bump the version number in this PR or is that a separate PR?

good point, will bump the version

@vkatz-pg vkatz-pg merged commit 576cf42 into main Jan 21, 2021
@vkatz-pg vkatz-pg deleted the async_init branch January 21, 2021 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants