-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop creating bookmarks when touching blocks that the selection is not in #38
Comments
Articulating some points better: Doing one bookmark per batch is nice. However, restoring bookmarks is expensive regardless of whether it actually does something visible to the user (because span removal is required, or checks are required.) Also, by creating the bookmark only once per batch, we create problems when you have multiple excessively large blocks. Because things are now more responsive, it's possible to do more things and get the selection restored to the wrong place. |
We need to:
|
I might be going insane but it's possible that with all the various changes we made along the way, that bookmarking is no longer needed (except for span removal) |
One ugly case we don't handle properly (which makes figuring out bookmarks difficult) - if a word is actually multiple text nodes and you type into the middle of it |
The render event already takes a rootElement. Is it sufficient to determine if the selection falls inside? |
I was talking through this problem and then realized this is horrible to do. This must be leftover cruft from the initial "touch the whole document" version.
The text was updated successfully, but these errors were encountered: