Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore file compares the whole line, not the link #38

Closed
jyn514 opened this issue Dec 1, 2020 · 4 comments
Closed

Ignore file compares the whole line, not the link #38

jyn514 opened this issue Dec 1, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@jyn514
Copy link
Contributor

jyn514 commented Dec 1, 2020

I have an idea for how to fix this and I'm interested in working on this myself.

Currently, this does nothing:

[ignore]
"`handle_alloc_error`" = ["../../alloc/alloc/fn.handle_alloc_error.html"]

because intra-conv is looking at the whole line:

[src/config_file.rs:80] name = "    /// [`handle_alloc_error`]: "
[src/config_file.rs:80] value = "../../alloc/alloc/fn.handle_alloc_error.html"
core: alloc/global.rs
=====

   89:  "    /// [`handle_alloc_error`]: ../../alloc/alloc/fn.handle_alloc_error.html"
        "    /// [`handle_alloc_error`]: super::super::alloc::alloc::handle_alloc_error()"
@jyn514
Copy link
Contributor Author

jyn514 commented Dec 1, 2020

Ok I take it back I have no idea how to fix this 😆 originally I thought I could just calls link_parts a little earlier and compare that:

let parts = crate::link_parts::link_parts(link, ctx.options()).ok()?;

but that doesn't actually look at the header, it looks at the link. I don't know if the header is ever actually parsed?

@poliorcetics
Copy link
Owner

This is strange, I thought I had a test for that case. Obviously not !

Don't hesitate to submit a fix if you find the reason else I'll work on it before the week is over. 😄

@poliorcetics poliorcetics added the bug Something isn't working label Dec 1, 2020
@poliorcetics
Copy link
Owner

[src/config_file.rs:80] name = " /// [handle_alloc_error]: "

Ah well, I think I know where I'm doing my comparison wrong.

I don't know if the header is ever actually parsed

It's not used beyond comparison so it's cheaper to not split it in three. I have an idea on how to fix it.

@poliorcetics
Copy link
Owner

The issue should be fixed now, it was a completely silly mistake on my part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants