Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room upgrades and m.room.tombstone events. #47

Closed
poljar opened this issue Jul 28, 2019 · 4 comments
Closed

Room upgrades and m.room.tombstone events. #47

poljar opened this issue Jul 28, 2019 · 4 comments
Assignees
@PaarthShah
Labels
enhancement New feature or request events good first issue Good for newcomers help wanted Extra attention is needed

Comments

@poljar
Copy link
Collaborator

poljar commented Jul 28, 2019

Matrix supports room upgrades. Room upgrades are essentially killing off an existing room and suggesting users to move to the new room.

To support room upgrades nio will need to parse the m.room.tombstone state events and store relevant information from the event in the MatrixRoom object of the room. Mainly the successor room of the event, and upgraded rooms should remember their predecessors as well.

To achieve this a new event schema should be specified in nio/schemas.py and a new event in nio/events/room_events.py. After that the handle_event method of the MatrixRoom class needs to be enhanced to handle the new event.

Relevant spec entry: https://matrix.org/docs/spec/client_server/latest#id205
@poljar poljar added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers events labels Jul 28, 2019
@anoadragon453 anoadragon453 mentioned this issue Jun 10, 2020
Open
jadyndev added a commit to famedly/matrix-nio that referenced this issue Oct 21, 2021
@jadyndev
feat(room): Add m.room.tombstone event parsing
938a384 
ref: matrix-nio#47
jadyndev added a commit to famedly/matrix-nio that referenced this issue Oct 26, 2021
@jadyndev
feat(room): Add m.room.tombstone event parsing
76f34be 
ref: matrix-nio#47
jadyndev added a commit to famedly/matrix-nio that referenced this issue Oct 26, 2021
@jadyndev
feat(room): Add m.room.tombstone event parsing
f0870b0 
ref: matrix-nio#47
@jadyndev jadyndev mentioned this issue Oct 26, 2021
Merged
jadyndev added a commit to famedly/matrix-nio that referenced this issue Nov 4, 2021
@jadyndev
feat(room): Add m.room.tombstone event parsing
6ccc1e3 
ref: matrix-nio#47
@BURG3R5
Copy link
Contributor

BURG3R5 commented Mar 28, 2022 •
edited
Loading

@poljar Can you close this if it's resolved? It looks like #281 fixed this.

@jaller94
Copy link
Contributor

This feature is mentioned as unsupported in the README.md.
Upon completion, this info should get updated.

@PaarthShah
Copy link
Collaborator

I'm seeing that we support this now: I'll assign myself to update the README appropriately

@PaarthShah PaarthShah self-assigned this Jun 29, 2023
@PaarthShah
Copy link
Collaborator

README updated: 17e34e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaarthShah PaarthShah

Labels
enhancement New feature or request events good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@poljar @jaller94 @PaarthShah @BURG3R5