Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanatize Boxed type definitions (eg. Box<u64>) #1393

Closed
JoshOrndorff opened this issue Sep 13, 2019 · 1 comment · Fixed by #1395
Closed

Sanatize Boxed type definitions (eg. Box<u64>) #1393

JoshOrndorff opened this issue Sep 13, 2019 · 1 comment · Fixed by #1395

Comments

@JoshOrndorff
Copy link
Contributor

Types that use rstd::boxed::Box are declared to the api without the box wrapper. For example if my type is type BoxedInt = Box<u64> it should be declared to the api as { "BoxedInt": "u64" }.

However developers may reasonably guess that it should be declared as { "BoxedInt": "Box<u64>" } especially considering how Vec<_>s are declared. To lower the friction for new developers, it would be nice to automatically strip the unnecessary Box when it is supplied.

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants