Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Extrinsics length hack (when on testnets) #574

Closed
1 of 2 tasks
jacogr opened this issue Jan 11, 2019 · 3 comments · Fixed by #1900
Closed
1 of 2 tasks

Remove Extrinsics length hack (when on testnets) #574

jacogr opened this issue Jan 11, 2019 · 3 comments · Fixed by #1900

Comments

@jacogr
Copy link
Member

jacogr commented Jan 11, 2019

Introduced in #573 - still not available on testnets as of this writing, so cannot be done as of yet

Affected changes -

https://github.com/polkadot-js/api/pull/573/files/b92607ab766cde0231010ecb76558d1f7669fb65..af327c46cd4ce9f09893b92c9db277743a8bce79#diff-f98351eb7cb1460dd4aabbbd6027b0dbR50

@jacogr jacogr added this to To Do in @polkadot{.js} via automation Jan 11, 2019
@jacogr
Copy link
Member Author

jacogr commented Jan 11, 2019

The good thing is that the hack does work on the running testnets and a local dev node. (However, as we know - push in exactly the wrong values and it will fail - so urgency remains)

@jacogr jacogr changed the title Remove Extrinsics length hack when rolled out to Alexander & CC Remove Extrinsics length hack when on testnets Jan 20, 2019
@jacogr jacogr added this to the 1.0 milestone Jan 22, 2019
@jacogr jacogr changed the title Remove Extrinsics length hack when on testnets Remove Extrinsics length hack (when on testnets) Jan 23, 2019
@jacogr
Copy link
Member Author

jacogr commented May 16, 2019

Looking at a network after Alex to reset this - as it stands, old info without is still in the early blocks. (So when you need to parse, it is needed)

@polkadot{.js} automation moved this from To Do to Done Feb 19, 2020
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants