Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change reactive onChange callback to rxChange #118

Closed
jacogr opened this issue Jun 30, 2018 · 1 comment · Fixed by #240
Closed

Change reactive onChange callback to rxChange #118

jacogr opened this issue Jun 30, 2018 · 1 comment · Fixed by #240
Projects
@polkadot{.js}

Comments

@jacogr
Copy link
Member

jacogr commented Jun 30, 2018

There are some magic hacks in there now where onChange is not pushed through since the component being wrapped could need it. Check for the onChange handlers and change the source, making it explicit and less black-magic -

https://github.com/polkadot-js/apps/blob/master/packages/ui-react-rx/src/with/observable.tsx#L94
@jacogr jacogr added the @ui label Jun 30, 2018
@jacogr jacogr added this to To Do in @polkadot{.js} via automation Jun 30, 2018
@jacogr jacogr changed the title Change onChange callback (rx-with*) to rxChange Change reactive onChange callback to rxChange Jul 12, 2018
@jacogr jacogr mentioned this issue Aug 20, 2018
Merged
@polkadot{.js} automation moved this from To Do to Done Aug 20, 2018
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
@polkadot{.js}
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Keyring observable subject around available options polkadot-js/apps
2 participants
@jacogr @polkadot-js-bot