Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any plan on i18n? #1421

Closed
exrobbie opened this issue Jul 19, 2019 · 9 comments
Closed

Is there any plan on i18n? #1421

exrobbie opened this issue Jul 19, 2019 · 9 comments

Comments

@exrobbie
Copy link

exrobbie commented Jul 19, 2019

Hi, this is definex.io from China. We appreciate your excellent works and have a question on i18n.

We saw you have already coded locales files but it doesn't have any contents, do you have any plan on i18n? We are glad to help if you need our assistant to translate Chinese.

@jacogr
Copy link
Member

jacogr commented Jul 19, 2019

Yes, the plan has always been to support i18.l All through the UI all the strings are already using a i18n layer (in our case https://www.i18next.com/) everywhere in the interface. So technically the answer is a resounding "yes".

When it comes to actually doing it, things are slightly more tricky, just because we have not had translations as of yet - the first one is always more involved while we get the process smooth.

As a first step, we need to exact the actual contents of the strings for translation - I'll take a look through the i18next-* utilities as how to best do this. Once done it really is just a matter of providing translations of those strings. (Which is no-doubt a lot of effort, as well as keeping it updated).

@exrobbie
Copy link
Author

We can provide Chinese translations and keep them updated for you. Do you have a schedule to do the i18n?

@jacogr
Copy link
Member

jacogr commented Jul 19, 2019

There are no reasons to not start at this point - the only stumbling block atm is just making the strings available, but there are tools for that, so just need to find the right one to extract it into a usable format.

So just give me a couple of days to catch breath and will take a look and we can get the ball rolling.

@exrobbie
Copy link
Author

That would be great, thank you so much.

@jacogr
Copy link
Member

jacogr commented Aug 6, 2019

My humble apologies for the very long delay in getting back to this - In #1478 has run the i18next tool against the codebase to extract. (The locales to extract for is configure in the config file, for now just extracting it to a default "en" to see the effect, so we would add "cn" here as well)

The good news is that all the strings are extracted without issues. What I don't like about this is that it is mostly uncategorised, so it is just a bundle of data without context. So some playing is still required to get some categories going, even . if that means having to specify each section seperately.

@exrobbie
Copy link
Author

Thank you for you excellent work, please don't hesitate to contact us if there's anything we could help.

@jacogr
Copy link
Member

jacogr commented Oct 11, 2019

And we actually have properly extracted strings now after #1710 . So we can actually get this done.

@jacogr
Copy link
Member

jacogr commented Jan 13, 2020

Closing, translations in after #2086

@jacogr jacogr closed this as completed Jan 13, 2020
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants