Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework reward caching #1931

Closed
jacogr opened this issue Nov 23, 2019 · 1 comment · Fixed by #1935
Closed

Rework reward caching #1931

jacogr opened this issue Nov 23, 2019 · 1 comment · Fixed by #1935

Comments

@jacogr
Copy link
Member

jacogr commented Nov 23, 2019

Currently we get this (when the user has not visited for a while) -

image

The drop-off there on 342 is because of an incomplete session. We should rather track to make sure we have rewards for all era-ends. (Bit tricky generally, since not all epoch ends are era ends as per current.)

So probably need to add a flag to make sure it is indeed session-ending. If not, discard.

Currently we always re-load at least a full era, which is wasteful on each load - and well, if you stay . away fro 2 days, you have issues.

@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants