Staking not working for older substrate versions

[JelliedOwl]

It looks like a recent change has broken the staking pages for some of the old substrate version chains. For example https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Fmainnet.edgewa.re (but I've seen other chains it's also not working for).

As far as I can tell, the format for the response to staking --> erasValidatorsPrefs has changed and the old format isn't being parsed any more. Is there any possibility of a fix to make it work with the old and new format (assuming that's really the issue)?

[jacogr]

This is actually not related to the UI at all and nothing that can be fixed here. The teams themselves are managing the types, in this case it seems that the ValidatorPrefs structure is incorrect, i.e. it just uses the API default which is the last version before metadata v14 was introduced.

It doesn't seem like there is any definition for this type in https://github.com/hicommonwealth/edgeware-node-types/blob/master/src/interfaces/definitions.ts - so basically since it is not specified, the UI just uses the type it has available.

There could be a breakage introduced by the API, but it won't be re-instated. In the past the API did it's best to try and detect types in various fashions, however it was not always spot-on with more-or-less a 95% success rate, getting some wrong. Since metadata v14 was introduced that problematic path was removed.

[JelliedOwl]

Thanks @jacogr. Does that mean the only fix would require an upgrade on the Edgeware side, or is it something we can update without needing to change the on-chain executable? Sorry, I'm decidedly vague on how it works.

[jacogr]

The package I linked to, https://github.com/hicommonwealth/edgeware-node-types/, needs to specify the correct ValidatorsPrefs type, it would probably be -

ValidatorPrefs: { commission: 'Compact<Perbill>' }

[JelliedOwl]

Ah, and then it gets pulled in from here: https://github.com/polkadot-js/apps/blob/master/packages/apps-config/src/api/spec/edgeware.ts

Thanks - I'll see if I can get it updated on the Edgeware end.

[polkadot-js-bot]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.