Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Cargo.lock in repo #14

Closed
dotlambda opened this issue Jan 19, 2023 · 2 comments
Closed

Include Cargo.lock in repo #14

dotlambda opened this issue Jan 19, 2023 · 2 comments

Comments

@dotlambda
Copy link

dotlambda commented Jan 19, 2023

That would make it easier for distributions to package py-sr25519-bindings.
See also rust-lang/cargo#315.

@arjanz
Copy link
Member

arjanz commented Jan 20, 2023

But what I read in the link you provided is that Cargo.lock should not be included for libraries? (rust-lang/cargo#315 (comment))

Rust docs also state the same: https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

@dotlambda
Copy link
Author

dotlambda commented Jan 20, 2023

But what I read in the link you provided is that Cargo.lock should not be included for libraries?

Yes, it shouldn't be included for Rust libraries.
Your Python library however is at the end of the Rust dependency chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants