Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests #6

Open
mostaphaRoudsari opened this issue Feb 7, 2021 · 1 comment
Open

add tests #6

mostaphaRoudsari opened this issue Feb 7, 2021 · 1 comment
Labels
P2-Important: ⚠️ RFC/Discussion 💬 Request for Comments / Discussion

Comments

@mostaphaRoudsari
Copy link
Member

I can think of two different approaches to set-up tests for this repository and none is ideal.

  1. convert to luigi pipeline and run the translated recipe - this approach will catch the issues in the recipe but will not catch any pollination-specific issues.
  2. push to pollination and run a test - In this case the recipe is already pushed to pollination so it might be too late to learn about the issue.

@AntoineDao, what are your thoughts about the best approach here?

@mostaphaRoudsari mostaphaRoudsari added P2-Important: ⚠️ RFC/Discussion 💬 Request for Comments / Discussion labels Feb 7, 2021
@AntoineDao
Copy link
Member

AntoineDao commented Feb 8, 2021

We could use queenbee-argo with a special "CI" config to schedule the runs on our staging cluster and somehow track the outputs.

The recipe could be scheduled like the one in this example.

Tracking the recipe would be trickier... I would propose adding some special start/end handling system inside of queenbee-argo so it scheduled modified argo workflows that communicate with the github API to create check suites.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2-Important: ⚠️ RFC/Discussion 💬 Request for Comments / Discussion
Projects
None yet
Development

No branches or pull requests

2 participants