Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add top-borders when accounts page is sorted by date #3

Open
polltery opened this issue May 28, 2024 · 0 comments
Open

Only add top-borders when accounts page is sorted by date #3

polltery opened this issue May 28, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@polltery
Copy link
Owner

polltery commented May 28, 2024

Currently the top borders are added on page load and whenever any date element is added, but it's pretty useless when this happens.. I recommend we add a check so this only works when account page is sorted by date.

I did some r&d and i think this function can help check if account is sorted by date..

document.querySelector('.is-sorting').classList.contains('ynab-grid-cell-date')

Also update the date box to show (Y+) with a tooltip to let the users know the plugin is loaded and working
image

@polltery polltery added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 28, 2024
@polltery polltery removed the help wanted Extra attention is needed label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant