Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReLu function max(0,a) gives 0 #33

Closed
jeromecy opened this issue Dec 1, 2021 · 3 comments
Closed

ReLu function max(0,a) gives 0 #33

jeromecy opened this issue Dec 1, 2021 · 3 comments

Comments

@jeromecy
Copy link

jeromecy commented Dec 1, 2021

Using Ladybug pic as an example, the ReLU function after the top one layer (orange colour) gives 0 when the max value is not zero. For example, I got max(0,0.64)=0. Should it be 0.64? Thank you.

@xiaohk
Copy link
Member

xiaohk commented Dec 1, 2021

Hello @jeromecy, thanks for reaching out to us!

In which ReLU layer did you see the max(0, 0.64)=0 case?

I am looking at the relu_2_2 layer for the laydybug pic and it looks correct.

image

image

@jeromecy
Copy link
Author

jeromecy commented Dec 2, 2021

Hi @xiaohk , many thanks for the reply. I apologies that it was my bad. The negative sign is too small on my screen, and I didn't notice it. After zooming in, I can see it clearly. Thank you so much!

@jeromecy jeromecy closed this as completed Dec 2, 2021
@xiaohk
Copy link
Member

xiaohk commented Dec 2, 2021

Hey @jeromecy, you should not apologize! It's a legit usability issue, and we should apologize for the confusion. Thanks again for raising the issue so we can improve the design!

In b9c1759 I changed the original - sign (Hyphen-Minus) to a longer sign (Fullwidth Hyphen-Minus). I hope it can help. Below is a before and after comparison.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants