Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing chargeUpkeep script #33

Closed
AsYlum- opened this issue Jul 29, 2020 · 2 comments
Closed

Missing chargeUpkeep script #33

AsYlum- opened this issue Jul 29, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@AsYlum-
Copy link
Contributor

AsYlum- commented Jul 29, 2020

In scripts/misc/logon.src in function RestoreMods around line 470 we can find:

start_script(":combat:chargeUpkeep", parms);

but this script does not exist in modernDistro package.

also there are calls through start_script inside pkg/systems/combat/include/equip.inc

@Admin-Yukiko
Copy link
Contributor

I will look into start_script(":combat:chargeUpkeep", parms). It's probably a leftover from the old combat system. This is an example of why any logon, logoff or reconnect script that is central to a package should be in that package. The main logon script should only have general functions and not be complicated with package-specific functions to be performed during logging on or off.
"also there are calls through start_script inside pkg/systems/combat/include/equip.inc". Thanks. I will look at that also.

@Admin-Yukiko Admin-Yukiko added the bug Something isn't working label Jul 30, 2020
Admin-Yukiko pushed a commit that referenced this issue Apr 22, 2021
… in :combat:. Sorry it took so long.

Added wrestlingHitScript.src to :combat:.
@Admin-Yukiko
Copy link
Contributor

Finally fixed this issue. I am sorry it took me so long. I guess I need to visit the repo's website more often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants