Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support two-dimensional masks #37

Open
polsys opened this issue Jun 11, 2020 · 1 comment
Open

Support two-dimensional masks #37

polsys opened this issue Jun 11, 2020 · 1 comment
Labels
quality of life Small improvements making a big difference.
Milestone
Possibly in the f...

Comments

@polsys
Copy link
Owner

polsys commented Jun 11, 2020 •
edited

Allow all masks that can be broadcasted to the shape of x. This would enable specifying a separate mask for each x variable, or even some more advanced scenarios.

For estimate_entropywith multidim=True, the masks should be combined, or two-dimensional masks be disallowed.
@polsys polsys added the quality of life Small improvements making a big difference. label Jun 11, 2020
@polsys polsys added this to the Beta 1 milestone Jun 11, 2020
@polsys polsys mentioned this issue Jun 12, 2020
Closed
@polsys
Copy link
Owner Author

polsys commented Jul 29, 2020

This is less necessary with the drop_nan support. I think this might still need more design and is not high-priority either. Moving to post 1.0.

@polsys polsys modified the milestones: Beta 1, Post 1.0 Jul 29, 2020
@polsys polsys modified the milestones: 1.1, Possibly in the future Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quality of life Small improvements making a big difference.
Projects
None yet
Milestone
Possibly in the future
Development

No branches or pull requests
1 participant
@polsys