Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Usability Of CycleRange And RepeatRange For Already Materialized Sequences #773

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Improve Usability Of CycleRange And RepeatRange For Already Materialized Sequences #773

wants to merge 1 commit into from

Conversation

bash
Copy link
Member

@bash bash commented Nov 30, 2023 •
edited

Resolves #740

  • Fix tests
  • Async

@bash
Copy link
Member Author

bash commented Nov 30, 2023 •
edited by FreeApophis

Open Questions

  • Do we want this at all?
  • This is a source breaking change as the return type for IReadOnlyCollection is different. Are we OK with this or should I rename the new overloads?

@bash bash marked this pull request as draft November 30, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FreeApophis FreeApophis Awaiting requested review from FreeApophis

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usability of CycleRange and RepeatRange
1 participant
@bash