Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable providing custom git config params for git repository connections #1179

Closed
Ohtar10 opened this issue Dec 1, 2020 · 1 comment
Closed

Comments

@Ohtar10
Copy link
Contributor

Ohtar10 commented Dec 1, 2020

Current behavior

Right now, If I want to work with a private repository, which runs with a self-signed certificate, If I do not want nor cannot configure a global git config option http.sslVerify=falsein the worker nodes to bypass this check, I can simply clone a repository via git -c http.sslVerify=false clone https://private.git.server/some/repo.

With polyaxon however, it seems there is no way to pass such configuration options in the connection entries nor in the git dictionary when interacting with repositories. This forces the user to configure the workers with the necessary changes to enable cloning from repositories running with self-signed certificates.

Enhancement

It would be nice to have an option to specify custom git configuration options per connection so users can add these properties and work effortlessly with these kinds of repositories.

As per slack chat with Bastian, this might be added to the schema setting of connections.

@polyaxon-team
Copy link
Contributor

A new field will be provided with the git schema:

url: ..,
revision: ...
flags: ["--force", "--anotherFlag", "--recursive", "-c http.sslVerify=false"]

Those additional flags will be added to the command and can be set globally on the connection definition, or can be used on per operation using the init git section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants