Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to turn off struts #2769

Closed
patrick96 opened this issue Jul 16, 2022 Discussed in #2768 · 2 comments · Fixed by #2844
Closed

Option to turn off struts #2769

patrick96 opened this issue Jul 16, 2022 Discussed in #2768 · 2 comments · Fixed by #2844
Assignees
Milestone

Comments

@patrick96
Copy link
Member

Discussed in #2768

Originally posted by patrick96 July 16, 2022
Polybar's struts can cover entire monitors if polybar is placed on a monitor that is in the middle of the X root screen. See also previous issues with tint2: https://gitlab.gnome.org/GNOME/mutter/-/issues/452

There was also a report for this on reddit

Ideally, WMs would compensate for that and only apply the parts of the struts which do not cover entire screens. However, many don't.

On the polybar side, the only conforming solution seems to be to just turn off struts.

For this, we should give the user an option in the bar section to enable/disable struts (enabled by default).
If struts are disabled, global/wm.margin-{top,bottom} being set, should produce a warning, because they are ignored.

@VanillaViking
Copy link
Contributor

VanillaViking commented Oct 17, 2022

Hi, I would like to work on this. so, bar::reconfigure_struts() should be only be able to run if a new struts option is set to true ?
Is this the correct way to implement it?

@patrick96
Copy link
Member Author

Yes, I think that would be good solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants