-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests break with python 3.5.2 #107
Labels
Comments
You mean this one?
|
Travis didn't catch that one. It caught 2 other tests : |
RemiCardona
added a commit
that referenced
this issue
Sep 23, 2016
Starting with 3.5.2, the writer object is set to None in the stream protocol. Ideally, we should prevent further use of the protocol object once the connection is closing or is closed. But until we do, just make sure we don't call close() twice as it's just silly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://travis-ci.org/Polyconseil/aioamqp/jobs/153019740
Travis switched from python 3.5.0 to 3.5.2 since the last master build and so this went unnoticed.
The upstream asyncio commit that broke the code is likely to be https://hg.python.org/cpython/rev/d1479e05ed0f. On our side, 1f5460a is most likely the guilty patch (though I don't think we want to revert that patch since the upstream commit was probably made for a very good reason).
Will look at it ASAP.
The text was updated successfully, but these errors were encountered: