Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in spelling of (un)marshaler. #3

Closed
dmitshur opened this issue Jul 6, 2017 · 2 comments
Closed

Inconsistency in spelling of (un)marshaler. #3

dmitshur opened this issue Jul 6, 2017 · 2 comments

Comments

@dmitshur
Copy link

dmitshur commented Jul 6, 2017

The README says things like:

pair cbor.Decoder with obj.Unmarshaller to get a cbor deserializer.

When I look at https://godoc.org/github.com/polydawn/refmt/obj, I don't find obj.Unmarshaller there.

That's because it's spelled with a single l rather than double l in code:

https://godoc.org/github.com/polydawn/refmt/obj#NewUnmarshaler

I've done a quick search, and it's not just README that's inconsistent, there's some internal code that uses different variations:

Note, the Go project uses the single l variation. See https://dmitri.shuralyov.com/idiomatic-go#use-consistent-spelling-of-certain-words for reference.

@TripleDogDare
Copy link
Member

Thanks, Dmitri!

@TripleDogDare
Copy link
Member

This should be fixed so I'm closing it. Let us know if you have any other comments. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants