Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cities to convert #22

Open
meetar opened this issue Feb 17, 2016 · 4 comments
Open

Cities to convert #22

meetar opened this issue Feb 17, 2016 · 4 comments

Comments

@meetar
Copy link
Member

meetar commented Feb 17, 2016

based on https://github.com/polygon-city/polygon-city-app/issues/48

@robhawkes
Copy link
Contributor

robhawkes commented Feb 18, 2016

I'll keep this table updated with data sources…

City Licence Format Notes
Berlin, Germany Licence CityGML (LOD2) Few, huge CityGML files
Toronto, Canada Licence DWG, DGN & SKP
Lyon, France Licence CityGML (LOD2) Models are at block level
Hamburg, Germany Licence CityGML (LOD1) LOD2 due late 2016
Montreal, Canada Licence CityGML (LOD2) & 3DM
Rotterdam, Netherlands Undisclosed CityGML (LOD2) Validation issues during conversion
NYC, US Undisclosed CityGML (LOD1)
NYC, US Official! ? CityGML (LOD1/LOD2) A few large files
Linz, Austria Undisclosed CityGML (LOD2) Lots of small CityGML files
Copenhagen, Denmark Licence DWG, DGN & DXF

@robhawkes robhawkes changed the title cities to convert Cities to convert Feb 26, 2016
@robhawkes
Copy link
Contributor

I had a play with the new, official NYC data and the results are promising!

Unfortunately, it seems like the converter isn't working correctly for some buildings (eg. the library) but I've not put any effort in to work out what exactly is failing here but the result is that same faces are flipped. Looks like either the geometry is invalid, or the obj-conversion / repair operations are doing things they shouldn't be (like flipping faces that were actually valid to begin with). It may actually make sense to provide an option to disable validation checks and repairs as if the data is 100% valid anyway then it may produce more reliable results.

@meetar
Copy link
Member Author

meetar commented Apr 20, 2016

Yes, I noticed that too but haven't had the chance to look more closely at it. I like the idea of making validation an option, though.

On Apr 20, 2016, at 6:21 AM, Robin Hawkes notifications@github.com wrote:

I had a play with the new, official NYC data and the results are promising!

Unfortunately, it seems like the converter isn't working correctly for some buildings (eg. the library) but I've not put any effort in to work out what exactly is failing here but the result is that same faces are flipped. Looks like either the geometry is invalid, or the obj-conversion / repair operations are doing things they shouldn't be (like flipping faces that were actually valid to begin with). It may actually make sense to provide an option to disable validation checks and repairs as if the data is 100% valid anyway then it may produce more reliable results.


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

@robhawkes
Copy link
Contributor

From what I can see there are a few buildings that have overlapping geometry too which causes a lot of z-fighting, so my money is on a combination of bad / invalid geometry and edge-case issues with the converter / repair system I wrote.

Probably best to run it through val3dity and see what comes back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants