Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could you please update ktor version. 1.3.0 doesn't close connections. #5

Closed
belarusrulez opened this issue Jun 25, 2020 · 1 comment · Fixed by #6
Closed

Could you please update ktor version. 1.3.0 doesn't close connections. #5

belarusrulez opened this issue Jun 25, 2020 · 1 comment · Fixed by #6
Assignees
@mmoghaddam385

Comments

@belarusrulez
Copy link

belarusrulez commented Jun 25, 2020 •
edited
Loading

Could you please update ktor version. 1.3.0 doesn't close connections.
I've tested 1.3.1 it does.
issue was found using this client in java. max connections I've had was 1500+

image
@mmoghaddam385 mmoghaddam385 self-assigned this Jun 26, 2020
@mmoghaddam385 mmoghaddam385 linked a pull request Jun 26, 2020 that will close this issue
Bump ktor version to 1.3.1 to prevent leaked connections #6
Merged
@mmoghaddam385
Copy link
Contributor

Hey @belarusrulez, thanks for letting me know about this problem! I just created a new release with the updated ktor dependency (1.0.1), let me know if you have any other questions or suggestions for the SDK. Also, feel free to fork and make PRs in the future!

@mmoghaddam385 mmoghaddam385 reopened this Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmoghaddam385 mmoghaddam385

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump ktor version to 1.3.1 to prevent leaked connections polygon-io/client-jvm
2 participants
@belarusrulez @mmoghaddam385