Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After recent update, "Uncaught TypeError: Cannot set property 'opened' of undefined". #50

Closed
safizn opened this issue Feb 4, 2016 · 7 comments

Comments

@safizn
Copy link

safizn commented Feb 4, 2016

Getting errors in console, and the drawer doesn't appear at all, neither does the related hamburger button:
Uncaught TypeError: Cannot set property 'opened' of undefined
(anonymous function) @ app-drawer-layout.html:188
Debouncer.complete @ polymer-mini.html:2097
boundComplete @ polymer-mini.html:2076
Polymer.Async._atEndOfMicrotask @ polymer-mini.html:2053
window.MutationObserver.observe.characterData @ polymer-mini.html:2068

The anonymous function points to:
resetLayout: function() {
....
-> this.drawer.opened = !this.narrow;
....

err1
err2

@motss
Copy link

motss commented Feb 4, 2016

👍

@jcpilario
Copy link

seems you need to specifically use app-drawer element now on your app-drawer-layout

@motss
Copy link

motss commented Feb 4, 2016

@jcpilario You're right. Now no more specifying attribute drawer and main.

@motss
Copy link

motss commented Feb 4, 2016

It works and use swipe-open attribute on app-drawer to enable swiping which is not the default.

@safizn
Copy link
Author

safizn commented Feb 4, 2016

Okay, now its working. After I checked out the demos of app-drawer & app-drawer-layout, and applied the changes.
Also the previously "drawer-width" property that was applied to app-drawer-layout was removed. So now the way to change the width of drawer is as follows:

app-drawer {
    --app-drawer-content-container: {
         width: 320px;
    }
}

Everything works as expected. Thanks for your amazing work.

@safizn safizn closed this as completed Feb 4, 2016
@frankiefu
Copy link
Contributor

Sorry about the breaking changes. Yes we are still at pre-release and likely we are going to make changes that will break stuffs. We will try to see if we can put the breaking changes in the pre-release note next time.

@lephuhai
Copy link

Mmm .. I have the same issue, using app-drawer-layout

-Uncaught TypeError: Cannot set property 'opened' of undefined
+   (anonymous function)    @   app-drawer-layout.html:188

@myuseringithub , please expect your solved. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants