Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polymer.CarbonRoutingBehavior should be merged with <carbon-route> #2

Closed
cdata opened this issue Feb 10, 2016 · 0 comments
Closed

Polymer.CarbonRoutingBehavior should be merged with <carbon-route> #2

cdata opened this issue Feb 10, 2016 · 0 comments

Comments

@cdata
Copy link
Contributor

cdata commented Feb 10, 2016

Instead, we should rely on Polymer's new element inheritance features to enable shared implementation.

@rictic rictic closed this as completed in #3 Feb 10, 2016
@cdata cdata modified the milestone: public-release Feb 12, 2016
cdata pushed a commit that referenced this issue Sep 10, 2016
This change proposes that `tail` should be reset when a route
deactivates. This has two important side-effects that need to be
considered:

 1. Child routes that no longer match the current path will become
 "inactive". Note that this is already true today in some circumstances,
 but not others, so the change brings consistency across all types of
 route path changes.
 2. The `tail` values down a routing branch will blink on and off in
 ways that they did not before. This is important to consider for
 performance purposes.

Regarding #2, the justification for this change is that `data` will
still remain consistent despite any thrashing of the `tail`, so UI
state can rely on `data` to avoid thrashing.
cdata pushed a commit that referenced this issue Sep 10, 2016
This change proposes that `tail` should be reset when a route
deactivates. This has two important side-effects that need to be
considered:

 1. Child routes that no longer match the current path will become
 "inactive". Note that this is already true today in some circumstances,
 but not others, so the change brings consistency across all types of
 route path changes.
 2. The `tail` values down a routing branch will blink on and off in
 ways that they did not before. This is important to consider for
 performance purposes.

Regarding #2, the justification for this change is that `data` will
still remain consistent despite any thrashing of the `tail`, so UI
state can rely on `data` to avoid thrashing.
cdata pushed a commit that referenced this issue Sep 16, 2016
This change proposes that `tail` should be reset when a route
deactivates. This has two important side-effects that need to be
considered:

 1. Child routes that no longer match the current path will become
 "inactive". Note that this is already true today in some circumstances,
 but not others, so the change brings consistency across all types of
 route path changes.
 2. The `tail` values down a routing branch will blink on and off in
 ways that they did not before. This is important to consider for
 performance purposes.

Regarding #2, the justification for this change is that `data` will
still remain consistent despite any thrashing of the `tail`, so UI
state can rely on `data` to avoid thrashing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant