Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

someUniqueSessionKey in README/docs, but not in example #114

Open
davidmaxwaterman opened this issue Jun 30, 2017 · 0 comments
Open

someUniqueSessionKey in README/docs, but not in example #114

davidmaxwaterman opened this issue Jun 30, 2017 · 0 comments

Comments

@davidmaxwaterman
Copy link

https://www.webcomponents.org/element/PolymerElements/app-storage

and

https://github.com/PolymerElements/app-storage/blob/master/README.md

have text:

<app-indexeddb-mirror
    session="a-unique-session-key-413"
    key="cats"
    data="{{liveData}}"
    persisted-data="{{persistedData}}">
</app-indexeddb-mirror>
When someUniqueSessionKey changes to a different value, app-indexeddb-mirror will delete the local data it is persisting at the "cats" key.

The text someUniqueSessionKey seems to refer to some property/attribute in the example, but that text doesn't appear in the example at all. I might assume it is a-unique-session-key-413, but that isn't clear at all.

Please consider using a binding for the session property too, eg:

  session="[[someUniqueSessionKey]]``

if that is indeed how it is intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant