Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paper-checkbox label does not wrap correctly #103

Open
WoodyWoodsta opened this issue Jan 31, 2016 · 6 comments
Open

Paper-checkbox label does not wrap correctly #103

WoodyWoodsta opened this issue Jan 31, 2016 · 6 comments

Comments

@WoodyWoodsta
Copy link

Sizing the paper-checkbox element in any way such that the label starts to need to wrap causes the label to flow outside of the width of the element. The label appears to not wrap for a width that of the checkbox div outside of the entire element. In other words, getting rid of the checkbox div fixes the issue.

Below is the usage of the checkbox in my app (excuse the label 😝):
screenshot from 2016-01-31 22 28 49

And here is a reduced test case.

The issue is present in latest Firefox security release (44.0), as well as Chrome 50.0.2633.3. I don't have access to others.

@notwaldorf
Copy link
Contributor

This is true. I wonder if this could be fixed with a flex box, and forcing the items to align at the top

hcarmona added a commit to hcarmona/paper-checkbox that referenced this issue Aug 16, 2016
The label doesn't take into account the width of the checkbox. This change adds a margin to the right so that the text doesn't spill over.
hcarmona added a commit to hcarmona/paper-checkbox that referenced this issue Aug 23, 2016
@danbeam
Copy link
Contributor

danbeam commented Aug 23, 2016

@notwaldorf flex box would be swell, @hcarmona's fix would probably work as well, though

fyi: this is affecting chrome://md-settings

@danbeam
Copy link
Contributor

danbeam commented Aug 23, 2016

@notwaldorf
Copy link
Contributor

cc @bicknellr -- I am not paper-checkbox's keeper anymore :)

@danbeam
Copy link
Contributor

danbeam commented Sep 20, 2016

@tjsavage

@davidmaxwaterman
Copy link

this is still a problem - paper-checkbox#1.4.2 - the label only wraps when it touches the label of the checkbox next to it:

paper-checkbox-wrapping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants