Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issues related to batch processing #276

Closed
polymorpher opened this issue Apr 1, 2022 · 1 comment
Closed

Security issues related to batch processing #276

polymorpher opened this issue Apr 1, 2022 · 1 comment

Comments

@polymorpher
Copy link
Owner

The BATCH operation was introduced in v14, with the intent to streamline upgrade operations by packing some other operations together (e.g. transferring domains, and tracking tokens).

However, v15 introduced some operations requiring extra security (hence more authentications) without excluding them from a BATCH operation. This enables attackers to wrap these operations inside a BATCH operation, thereby executing these operations without doing more authentications as they would normally require.

To fix this, more verifications should be added to both the proof verification mechanism and the batch execution logic. Some operations should not be permitted inside BATCH, including BATCH itself.

@polymorpher
Copy link
Owner Author

Fixed in #275

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant