Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: AssemblyScript Automatic Object-Type JSON Serialization #846

Merged
merged 15 commits into from May 11, 2022
Merged

feat: AssemblyScript Automatic Object-Type JSON Serialization #846

merged 15 commits into from May 11, 2022

Conversation

Niraj-Kamdar
Copy link
Contributor

@Niraj-Kamdar Niraj-Kamdar commented May 10, 2022 •
edited

Changelog

  • Removed JSON type from scalar
  • Added a better JSON serializer for serializing object to string and vice-versa.
  • Not In this PR: Json type alias

Note: this will replace PR #817

@dOrgJelli dOrgJelli changed the title feat: add new json serializer feat: AssemblyScript Object-Type from/to Automatic JSON Serialization May 10, 2022
@dOrgJelli dOrgJelli changed the title feat: AssemblyScript Object-Type from/to Automatic JSON Serialization feat: AssemblyScript Automatic Object-Type JSON Serialization May 10, 2022
dOrgJelli
dOrgJelli previously approved these changes May 10, 2022
View reviewed changes
@dOrgJelli dOrgJelli changed the base branch from prealpha to prealpha-dev May 10, 2022 23:52
@dOrgJelli dOrgJelli dismissed their stale review May 10, 2022 23:52

The base branch was changed.

@dOrgJelli dOrgJelli merged commit 0e47148 into prealpha-dev May 11, 2022
This was referenced May 11, 2022
Merged
Closed
@cbrzn cbrzn mentioned this pull request Jun 21, 2022
Merged
@dOrgJelli dOrgJelli deleted the nk/serial-as-json-1 branch April 10, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dOrgJelli dOrgJelli dOrgJelli approved these changes

@krisbitney krisbitney Awaiting requested review from krisbitney

@namesty namesty Awaiting requested review from namesty namesty is a code owner

@nerfZael nerfZael Awaiting requested review from nerfZael nerfZael is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improved JSON Serialization Bindings For AssemblyScript Improve JSON serialization
2 participants
@Niraj-Kamdar @dOrgJelli